Break more lines before not after operators

System Internals / glibc - Joseph Myers [codesourcery.com] - 25 February 2019 13:19 EST

This patch makes further coding style fixes where code was breaking lines after an operator, contrary to the GNU Coding Standards. As with the previous patch, it is limited to files following a reasonable approximation to GNU style already, and is not exhaustive; more such issues remain to be fixed.

Tested for x86_64, and with build-many-glibcs.py.

- dirent/dirent.h [!_DIRENT_HAVE_D_NAMLEN && _DIRENT_HAVE_D_RECLEN] (_D_ALLOC_NAMLEN): Break lines before rather than after operators.
- elf/cache.c (print_cache): Likewise.
- gshadow/fgetsgent_r.c (__fgetsgent_r): Likewise.
- htl/pt-getattr.c (__pthread_getattr_np): Likewise.
- hurd/hurdinit.c (_hurd_setproc): Likewise.
- hurd/hurdkill.c (_hurd_sig_post): Likewise.
- hurd/hurdlookup.c (__file_name_lookup_under): Likewise.
- hurd/hurdsig.c (_hurd_internal_post_signal): Likewise. (reauth_proc): Likewise.
- hurd/lookup-at.c (__file_name_lookup_at): Likewise. (__file_name_split_at): Likewise. (__directory_name_split_at): Likewise.
- hurd/lookup-retry.c (__hurd_file_name_lookup_retry): Likewise.
- hurd/port2fd.c (_hurd_port2fd): Likewise.
- iconv/gconv_dl.c (do_print): Likewise.
- inet/netinet/in.h (struct sockaddr_in): Likewise.
- libio/wstrops.c (_IO_wstr_seekoff): Likewise.
- locale/setlocale.c (new_composite_name): Likewise.
- malloc/memusagestat.c (main): Likewise.
- misc/fstab.c (fstab_convert): Likewise.
- nptl/pthread_mutex_unlock.c (__pthread_mutex_unlock_usercnt): Likewise.
- nss/nss_compat/compat-grp.c (getgrent_next_nss): Likewise. (getgrent_next_file): Likewise. (internal_getgrnam_r): Likewise. (internal_getgrgid_r): Likewise.
- nss/nss_compat/compat-initgroups.c (getgrent_next_nss): Likewise. (internal_getgrent_r): Likewise.
- nss/nss_compat/compat-pwd.c (getpwent_next_nss_netgr): Likewise. (getpwent_next_nss): Likewise. (getpwent_next_file): Likewise. (internal_getpwnam_r): Likewise. (internal_getpwuid_r): Likewise.
- nss/nss_compat/compat-spwd.c (getspent_next_nss_netgr): Likewise. (getspent_next_nss): Likewise. (internal_getspnam_r): Likewise.
- pwd/fgetpwent_r.c (__fgetpwent_r): Likewise.
- shadow/fgetspent_r.c (__fgetspent_r): Likewise.
- string/strchr.c (STRCHR): Likewise.
- string/strchrnul.c (STRCHRNUL): Likewise.
- sysdeps/aarch64/fpu/fpu_control.h (_FPU_FPCR_IEEE): Likewise.
- sysdeps/aarch64/sfp-machine.h (_FP_CHOOSENAN): Likewise.
- sysdeps/csky/dl-machine.h (elf_machine_rela): Likewise.
- sysdeps/generic/memcopy.h (PAGE_COPY_FWD_MAYBE): Likewise.
- sysdeps/generic/symbol-hacks.h (__stack_chk_fail_local): Likewise.
- sysdeps/gnu/netinet/ip_icmp.h (ICMP_INFOTYPE): Likewise.
- sysdeps/gnu/updwtmp.c (TRANSFORM_UTMP_FILE_NAME): Likewise.
- sysdeps/gnu/utmp_file.c (TRANSFORM_UTMP_FILE_NAME): Likewise.
- sysdeps/hppa/jmpbuf-unwind.h (_JMPBUF_UNWINDS): Likewise.
- sysdeps/mach/hurd/bits/stat.h (S_ISPARE): Likewise.
- sysdeps/mach/hurd/dl-sysdep.c (_dl_sysdep_start): Likewise. (open_file): Likewise.
- sysdeps/mach/hurd/htl/pt-mutexattr-setprotocol.c (pthread_mutexattr_setprotocol): Likewise.
- sysdeps/mach/hurd/ioctl.c (__ioctl): Likewise.
- sysdeps/mach/hurd/mmap.c (__mmap): Likewise.
- sysdeps/mach/hurd/ptrace.c (ptrace): Likewise.
- sysdeps/mach/hurd/spawni.c (__spawni): Likewise.
- sysdeps/microblaze/dl-machine.h (elf_machine_type_class): Likewise. (elf_machine_rela): Likewise.
- sysdeps/mips/mips32/sfp-machine.h (_FP_CHOOSENAN): Likewise.
- sysdeps/mips/mips64/sfp-machine.h (_FP_CHOOSENAN): Likewise.
- sysdeps/mips/sys/asm.h (multiple #if conditionals): Likewise.
- sysdeps/posix/rename.c (rename): Likewise.
- sysdeps/powerpc/novmx-sigjmp.c (__novmx__sigjmp_save): Likewise.
- sysdeps/powerpc/sigjmp.c (__vmx__sigjmp_save): Likewise.
- sysdeps/s390/fpu/fenv_libc.h (FPC_VALID_MASK): Likewise.
- sysdeps/s390/utf8-utf16-z9.c (gconv_end): Likewise.
- sysdeps/unix/grantpt.c (grantpt): Likewise.
- sysdeps/unix/sysv/linux/a.out.h (N_TXTOFF): Likewise.
- sysdeps/unix/sysv/linux/updwtmp.c (TRANSFORM_UTMP_FILE_NAME): Likewise.
- sysdeps/unix/sysv/linux/utmp_file.c (TRANSFORM_UTMP_FILE_NAME): Likewise.
- sysdeps/x86/cpu-features.c (get_common_indices): Likewise.
- time/tzfile.c (__tzfile_compute): Likewise.

a04549c194 Break more lines before not after operators.
ChangeLog | 85 ++++++++++++++++++++++++
dirent/dirent.h | 4 +-
elf/cache.c | 4 +-
gshadow/fgetsgent_r.c | 6 +-
htl/pt-getattr.c | 6 +-
hurd/hurdinit.c | 8 +--
hurd/hurdkill.c | 4 +-
hurd/hurdlookup.c | 4 +-
hurd/hurdsig.c | 24 +++----
hurd/lookup-at.c | 12 ++--
hurd/lookup-retry.c | 8 +--
hurd/port2fd.c | 5 +-
iconv/gconv_dl.c | 6 +-
inet/netinet/in.h | 8 +--
libio/wstrops.c | 4 +-
locale/setlocale.c | 12 ++--
malloc/memusagestat.c | 4 +-
misc/fstab.c | 12 ++--
nptl/pthread_mutex_unlock.c | 5 +-
nss/nss_compat/compat-grp.c | 22 +++---
nss/nss_compat/compat-initgroups.c | 10 +--
nss/nss_compat/compat-pwd.c | 26 ++++----
nss/nss_compat/compat-spwd.c | 14 ++--
pwd/fgetpwent_r.c | 4 +-
shadow/fgetspent_r.c | 4 +-
string/strchr.c | 6 +-
string/strchrnul.c | 6 +-
sysdeps/aarch64/fpu/fpu_control.h | 6 +-
sysdeps/aarch64/sfp-machine.h | 4 +-
sysdeps/csky/dl-machine.h | 4 +-
sysdeps/generic/memcopy.h | 4 +-
sysdeps/generic/symbol-hacks.h | 4 +-
sysdeps/gnu/netinet/ip_icmp.h | 10 +--
sysdeps/gnu/updwtmp.c | 14 ++--
sysdeps/gnu/utmp_file.c | 14 ++--
sysdeps/hppa/jmpbuf-unwind.h | 4 +-
sysdeps/mach/hurd/bits/stat.h | 4 +-
sysdeps/mach/hurd/dl-sysdep.c | 8 +--
sysdeps/mach/hurd/htl/pt-mutexattr-setprotocol.c | 7 +-
sysdeps/mach/hurd/ioctl.c | 6 +-
sysdeps/mach/hurd/mmap.c | 4 +-
sysdeps/mach/hurd/ptrace.c | 4 +-
sysdeps/mach/hurd/spawni.c | 4 +-
sysdeps/microblaze/dl-machine.h | 14 ++--
sysdeps/mips/mips32/sfp-machine.h | 4 +-
sysdeps/mips/mips64/sfp-machine.h | 4 +-
sysdeps/mips/sys/asm.h | 16 ++---
sysdeps/posix/rename.c | 4 +-
sysdeps/powerpc/novmx-sigjmp.c | 6 +-
sysdeps/powerpc/sigjmp.c | 6 +-
sysdeps/s390/fpu/fenv_libc.h | 4 +-
sysdeps/s390/utf8-utf16-z9.c | 4 +-
sysdeps/unix/grantpt.c | 4 +-
sysdeps/unix/sysv/linux/a.out.h | 4 +-
sysdeps/unix/sysv/linux/updwtmp.c | 24 ++++---
sysdeps/unix/sysv/linux/utmp_file.c | 24 ++++---
sysdeps/x86/cpu-features.c | 8 +--
time/tzfile.c | 6 +-
58 files changed, 323 insertions(+), 223 deletions(-)

Upstream: sourceware.org


  • Share