Bug 20918 - Building with --enable-nss-crypt fails tst-linkall-static

System Internals / glibc - Carlos O'Donell [systemhalted.org] - 2 December 2016 14:39 UTC

Some configurations may use NSS cryptographic routines but have no static library for those routines. The following changes allow glibc to be built and tested with --enable-nss-crypt, but without having a static NSS library. At a high level the change does two things:

(1) Detect at configure time if static NSS crypto libraries are available. Assumes libfreebl3.a (instead of the existing Fedora libfreebl.a which is incomplete) which matches libfreebl3.so.

(2) If static NSS crypto libraries are _not_ available then adjust the way in which we build tst-linkall-static. This includes excluding a reference to crypt and not linking against libcrypt.a, all of which will fail otherwise.

Testing assumptions:
- Static library is named libfreebl3.a (not libfreebl.a as is currently provided in Fedora), matching libfreebl3.so shared link name.

Tested on x86_64 on Fedora with:

(a) --enable-nss-crypt, with no static NSS library support: PASS (previous FAIL)

(b) --enable-nss-crypt, with faked static NSS library support: PASS (unsupported)
- Requires changing elf/Makefile to include a stub /lib64/libfreebl3.a for testing purposes.

(c) --disable-nss-crypt: PASS (default)

No regressions on x86_64.

For details see: https://www.sourceware.org/ml/libc-alpha/2016-11/msg00647.html

84aa751 Bug 20918 - Building with --enable-nss-crypt fails tst-linkall-static
ChangeLog | 16 ++++++++++++++++
config.make.in | 1 +
configure | 29 +++++++++++++++++++++++++++++
configure.ac | 14 ++++++++++++++
elf/Makefile | 32 ++++++++++++++++++++++++++++++--
elf/tst-linkall-static.c | 2 ++
6 files changed, 92 insertions(+), 2 deletions(-)

Upstream: sourceware.org

  • Share