x86-64: Implement memset family IFUNC selectors in C

System Internals / glibc - H.J. Lu [gmail.com] - 15 June 2017 11:33 EDT

Implement memset family IFUNC selectors in C.

All internal calls within libc.so can use IFUNC on x86-64 since unlike x86, x86-64 supports PC-relative addressing to access the GOT entry so that it can call via PLT without using an extra register. For libc.a, we can't use IFUNC for functions which are called before IFUNC has been initialized. Use IFUNC internally reduces the icache footprint since libc.so and other codes in the process use the same implementations. This patch uses IFUNC for memset functions within libc.

2017-06-07 H.J. Lu Erich Elsen

- sysdeps/x86_64/multiarch/Makefile (sysdep_routines): Add memset-sse2-unaligned-erms, and memset_chk-nonshared.
- sysdeps/x86_64/multiarch/ifunc-impl-list.c (__libc_ifunc_impl_list): Add test for __memset_chk_erms. Update comments.
- sysdeps/x86_64/multiarch/ifunc-memset.h: New file.
- sysdeps/x86_64/multiarch/memset-sse2-unaligned-erms.S: Likewise.
- sysdeps/x86_64/multiarch/memset.c: Likewise.
- sysdeps/x86_64/multiarch/memset_chk-nonshared.S: Likewise.
- sysdeps/x86_64/multiarch/memset_chk.c: Likewise.
- sysdeps/x86_64/multiarch/memset.S: Removed.
- sysdeps/x86_64/multiarch/memset_chk.S: Likewise.
- sysdeps/x86_64/multiarch/memset-vec-unaligned-erms.S (__memset_chk_erms): New function.

93e46f8 x86-64: Implement memset family IFUNC selectors in C
ChangeLog | 18 +++++
sysdeps/x86_64/multiarch/Makefile | 3 +-
sysdeps/x86_64/multiarch/ifunc-impl-list.c | 6 +-
sysdeps/x86_64/multiarch/ifunc-memset.h | 69 ++++++++++++++++++
.../x86_64/multiarch/memset-sse2-unaligned-erms.S | 41 +++++++++++
.../x86_64/multiarch/memset-vec-unaligned-erms.S | 5 ++
sysdeps/x86_64/multiarch/memset.S | 82 ----------------------
sysdeps/x86_64/multiarch/memset.c | 37 ++++++++++
sysdeps/x86_64/multiarch/memset_chk-nonshared.S | 21 ++++++
sysdeps/x86_64/multiarch/memset_chk.S | 61 ----------------
sysdeps/x86_64/multiarch/memset_chk.c | 31 ++++++++
sysdeps/x86_64/multiarch/wmemset.c | 7 ++
sysdeps/x86_64/multiarch/wmemset_chk-nonshared.S | 2 +-
13 files changed, 236 insertions(+), 147 deletions(-)

Upstream: sourceware.org


  • Share