Add error handling to RenamePrgFolder and RemovePrgFolder

Desktop / LibreOffice - Samuel Mehrbrodt [allotropia.de] - 11 May 2022 12:18 UTC

These routines can fail during MSI installation (seen leftover program_old folders, with program folder missing).

We at least want to see the error in the MSI log file when this doesn't succeed.

This outputs error messages like:

MSI (s) (C4:5C) [10:47:54:280]: Invoking remote custom action. DLL: C:\Windows\Installer\MSI37B4.tmp, Entrypoint: RemovePrgFolder CustomAction RemovePrgFolder returned actual error code 1603 (note this may not be 100% accurate if translation happened inside sandbox) Action ended 10:47:54: RemovePrgFolder. Return value 3.

Change-Id: I4ce4099eeb3e0ee79eb4a2e1d3887f9810fd9669 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/134160

86453991a7ca Add error handling to RenamePrgFolder and RemovePrgFolder
.../customactions/shellextensions/vistaspecial.cxx | 22 ++++++++++++++++++----
1 file changed, 18 insertions(+), 4 deletions(-)

Upstream: cgit.freedesktop.org


  • Share