remove support for BITMASK in vcl backends

Desktop / LibreOffice - Noel Grandin [collabora.co.uk] - 29 April 2021 06:40 UTC

Rather use a proper alpha channel if we need transparency.

This is another small step towards merged alpha in our vcl layer.

I suspect the intent in a lot of this code was to save memory. Which have been a thing way back then, but these days our backends mostly end up doing a copy-and-convert to a real alpha channel anyway, so the existing code is actually now a pessimisation.

Change-Id: I4a2bcbb2f76b841f05bc00580f364492829c69de Reviewed-on: https://gerrit.libreoffice.org/c/core/+/114808

b153d147c9d8 remove support for BITMASK in vcl backends
canvas/source/vcl/backbuffer.cxx | 9 ++-------
canvas/source/vcl/backbuffer.hxx | 11 ++---------
canvas/source/vcl/canvascustomsprite.cxx | 5 ++---
cui/source/dialogs/screenshotannotationdlg.cxx | 2 +-
.../source/primitive2d/graphicprimitivehelper2d.cxx | 2 +-
filter/source/msfilter/msdffimp.cxx | 2 +-
include/vcl/salgtype.hxx | 1 -
include/vcl/virdev.hxx | 21 +++++++--------------
sc/source/core/data/documen8.cxx | 2 +-
sc/source/ui/cctrl/tbzoomsliderctrl.cxx | 2 +-
slideshow/source/engine/shapes/gdimtftools.cxx | 2 +-
.../customshapes/EnhancedCustomShapeFontWork.cxx | 4 ++--
sw/source/core/doc/DocumentDeviceManager.cxx | 2 +-
vcl/headless/svpinst.cxx | 4 ++--
vcl/headless/svpvd.cxx | 12 +++---------
vcl/inc/headless/svpvd.hxx | 3 +--
vcl/inc/qt5/Qt5VirtualDevice.hxx | 3 +--
vcl/qa/cppunit/lifecycle.cxx | 2 +-
vcl/qt5/Qt5Instance.cxx | 6 +++---
vcl/qt5/Qt5SvpVirtualDevice.hxx | 5 ++---
vcl/qt5/Qt5VirtualDevice.cxx | 18 +++++-------------
vcl/quartz/salvd.cxx | 3 ---
vcl/source/bitmap/BitmapEx.cxx | 3 +--
vcl/source/filter/eps/eps.cxx | 2 +-
vcl/source/gdi/virdev.cxx | 13 +------------
vcl/source/outdev/text.cxx | 2 +-
vcl/source/outdev/transparent.cxx | 2 +-
vcl/unx/generic/gdi/cairo_xlib_cairo.cxx | 9 ++-------
vcl/unx/generic/gdi/salvd.cxx | 15 ++-------------
vcl/unx/gtk3/gtk3gtkinst.cxx | 4 ++--
vcl/win/gdi/salvd.cxx | 5 ++---
31 files changed, 53 insertions(+), 123 deletions(-)

Upstream: cgit.freedesktop.org


  • Share