sc_ucalc: use DoLoad instead of DoInitNew

Desktop / LibreOffice - Xisco Fauli [libreoffice.org] - 17 May 2021 15:46 UTC

In 145b2d8ee131dca592a41f7b26341a542a23845b I wrongly assumed that the formula options have to be reset back to default after using them. Later, I realized that was not the reason why some tests didn't fail when executed individually but failed when the module was executed as a whole. After some investigation, it turned out the problem was caused by DoInitNew changing the defaults separators. Why? I don't know, but using DoLoad seems to fix this problem

This change revealed that Test::testMatrixConditionalBooleanResult, Test::testFormulaWizardSubformula and Test::testTdf93415 were relying on other tests and failed if executed individually. Adapt them to use the default separators.

Change-Id: I08c1d88d7c6411592cc9a5779bfaa2b3bb6429ff Reviewed-on: https://gerrit.libreoffice.org/c/core/+/115704

9bbf8057d9d9 sc_ucalc: use DoLoad instead of DoInitNew
sc/qa/unit/ucalc.cxx | 30 ++--------
sc/qa/unit/ucalc_copypaste.cxx | 112 ++-----------------------------------
sc/qa/unit/ucalc_formula.cxx | 62 ++------------------
sc/qa/unit/ucalc_sharedformula.cxx | 2 +-
sc/qa/unit/ucalc_sort.cxx | 10 ----
5 files changed, 15 insertions(+), 201 deletions(-)

Upstream: cgit.freedesktop.org


  • Share