Create foreign key triggers in partitioned tables too

Enterprise / PostgreSQL - Alvaro Herrera [] - 5 January 2022 22:00 UTC

While user-defined triggers defined on a partitioned table have a catalog definition for both it and its partitions, internal triggers used by foreign keys defined on partitioned tables only have a catalog definition for its partitions. This commit fixes that so that partitioned tables get the foreign key triggers too, just like user-defined triggers. Moreover, like user-defined triggers, partitions' internal triggers will now also have their tgparentid set appropriately. This is to allow subsequent commit(s) to make the foreign key related events to be fired in some cases using the parent table triggers instead of those of partitions'.

This also changes what tgisinternal means in some cases. Currently, it means either that the trigger is an internal implementation object of a foreign key constraint, or a "child" trigger on a partition cloned from the trigger on the parent. This commit changes it to only mean the former to avoid confusion. As for the latter, it can be told by tgparentid being nonzero, which is now true both for user-defined and foreign key's internal triggers.

Author: Amit Langote

f4566345cf Create foreign key triggers in partitioned tables too
src/backend/commands/tablecmds.c | 413 +++++++++++++++++++++++++++------
src/backend/commands/trigger.c | 101 +++++++-
src/bin/pg_dump/pg_dump.c | 46 +++-
src/bin/pg_dump/pg_dump.h | 2 +-
src/bin/psql/describe.c | 10 +-
src/include/commands/trigger.h | 4 +
src/test/regress/expected/triggers.out | 4 +-
7 files changed, 490 insertions(+), 90 deletions(-)


  • Share