Fix incorrect comment for get_agg_clause_costs

Enterprise / PostgreSQL - David Rowley [postgresql.org] - 26 July 2021 02:55 UTC

Adjust the header comment in get_agg_clause_costs so that it matches what the function currently does. No recursive searching has been done ever since 0a2bc5d61. It also does not determine the aggtranstype like the comment claimed. That's all done in preprocess_aggref(). preprocess_aggref also now determines the numOrderedAggs, so remove the mention that get_agg_clause_costs also calculates "counts".

Normally, since this is just an adjustment of a comment it might not be worth back-patching, but since this code is new to PG14 and that version is still in beta, then it seems worth having the comments match.

Discussion: https://postgr.es/m/CAApHDvrrGrTJFPELrjx0CnDtz9B7Jy2XYW3Z2BKifAWLSaJYwQ@mail.gmail.com Backpatch-though: 14

2b58f894e5 Fix incorrect comment for get_agg_clause_costs
src/backend/optimizer/prep/prepagg.c | 28 ++++++++++++----------------
1 file changed, 12 insertions(+), 16 deletions(-)

Upstream: git.postgresql.org


  • Share