Flexible options for BASE_BACKUP.

Enterprise / PostgreSQL - Robert Haas [postgresql.org] - 5 October 2021 15:50 UTC

Previously, BASE_BACKUP used an entirely hard-coded syntax, but that's hard to extend. Instead, adopt the same kind of syntax we've used for SQL commands such as VACUUM, ANALYZE, COPY, and EXPLAIN, where it's not necessary for all of the option names to be parser keywords.

In the new syntax, most of the options now take an optional Boolean argument. To match our practice in other in places, the options which the old syntax called NOWAIT and NOVERIFY_CHECKSUMS options are in the new syntax called WAIT and VERIFY_CHECKUMS, and the default value is false. In the new syntax, the FAST option has been replaced by a CHECKSUM option whose value may be 'fast' or 'spread'.

This commit does not remove support for the old syntax. It just adds the new one as an additional option, and makes pg_basebackup prefer the new syntax when the server is new enough to support it.

Patch by me, reviewed and tested by Fabien Coelho, Sergei Kornilov, Fujii Masao, and Tushar Ahuja.

Discussion: http://postgr.es/m/CA+TgmobAczXDRO_Gr2euo_TxgzaH1JxbNxvFx=HYvBinefNH8Q@mail.gmail.com Discussion: http://postgr.es/m/CA+TgmoZGwR=ZVWFeecncubEyPdwghnvfkkdBe9BLccLSiqdf9Q@mail.gmail.com

0ba281cb4b Flexible options for BASE_BACKUP.
doc/src/sgml/protocol.sgml | 67 ++++++++++++++----------
src/backend/replication/basebackup.c | 51 +++++++++++-------
src/backend/replication/repl_gram.y | 97 ++++++++++++++++++++++++++++++-----
src/bin/pg_basebackup/pg_basebackup.c | 71 ++++++++++++++++---------
src/bin/pg_basebackup/streamutil.c | 61 ++++++++++++++++++++++
src/bin/pg_basebackup/streamutil.h | 12 +++++
6 files changed, 276 insertions(+), 83 deletions(-)

Upstream: git.postgresql.org


  • Share