xwayland: Use a fixed DPI value for core protocol

Graphics / X.Org / X.Org Server - Olivier Fourdan [redhat.com] - 3 July 2020 12:59 UTC

The way Xwayland works (like all Wayland clients), it first queries the Wayland registry, set up all relevant protocols and then initializes its own structures.

That means Xwayland will get the Wayland outputs from the Wayland compositor, compute the physical size of the combined outputs and set the corresponding Xwayland screen properties accordingly.

Then it creates the X11 screen using fbScreenInit() but does so by using a default DPI value of 96. That value is used to set the physical size of the X11 screen, hence overriding the value computed from the actual physical size provided by the Wayland compositor.

As a result, the DPI computed by tools such as xdpyinfo will always be 96 regardless of the actual screen size and resolution.

However, if the Wayland outputs get reconfigured, or new outputs added, or existing outputs removed, Xwayland will recompute and update the physical size of the screen, leading to an unexpected change of DPI.

To avoid that discrepancy, use a fixed size DPI (defaults to 96, and can be set using the standard command lime option "-dpi") and compute a physical screen size to match that DPI setting.

Note that only affects legacy core protocols, X11 clients can still get the actual physical output size as reported by the Wayland compositor using the RandR protocol, which also allows for the size to be 0 if the size is unknown or meaningless.

b0413b6e9 xwayland: Use a fixed DPI value for core protocol
hw/xwayland/xwayland-output.c | 41 ++---------------------------------------
hw/xwayland/xwayland-screen.c | 7 ++++++-
2 files changed, 8 insertions(+), 40 deletions(-)

Upstream: cgit.freedesktop.org

  • Share