y2038: Convert aio_suspend to support 64 bit time

System Internals / glibc - Lukasz Majewski [denx.de] - 30 November 2020 13:08 UTC

The aio_suspend function has been converted to support 64 bit time.

This change uses (in aio_misc.h):- __futex_abstimed_wait64 (instead of futex_reltimed_wait)- __futex_abstimed_wait_cancellable64 (instead of futex_reltimed_wait_cancellable) from ./sysdeps/nptl/futex-helpers.h

The aio_suspend() accepts relative timeout, which then is converted to absolute one.

The i686-gnu port (HURD) do not define DONT_NEED_AIO_MISC_COND and as it doesn't (yet) support 64 bit time it uses not converted pthread_cond_timedwait().

The __aio_suspend() is supposed to be run on ports with __TIMESIZE !=64 and __WORDSIZE==32. It internally utilizes __aio_suspend_time64() and hence the conversion from 32 bit struct timespec to 64 bit one is required.

For ports supporting 64 bit time the __aio_suspend_time64() will be used either via alias (to __aio_suspend when __TIMESIZE==64) or redirection (when -D_TIME_BITS=64 is passed).

Build tests: ./src/scripts/build-many-glibcs.py glibcs

cc5d5852c6 y2038: Convert aio_suspend to support 64 bit time
include/aio.h | 8 ++++++
nptl/Versions | 1 +
sysdeps/nptl/aio_misc.h | 11 +++++---
sysdeps/nptl/futex-internal.c | 2 ++
sysdeps/nptl/futex-internal.h | 6 +++--
sysdeps/pthread/aio_suspend.c | 60 +++++++++++++++++++++++++------------------
6 files changed, 57 insertions(+), 31 deletions(-)

Upstream: sourceware.org

  • Share