mmal/deinterlace: Do not use local buffer pools

Multimedia / VLC - Julian Scheel [jusst.de] - 5 June 2015 08:35 UTC

The mmal deinterlace filter does currently support the mmal opaque encoding only and thus must be used together with mmal vout and mmal codec. This ensures that pictures being used contain valid mmal buffer headers in the picture_sys. Using them instead of locally allocated buffer headers simplifies the code and avoids error-prone dangling with the data attached to the buffer headers. Furthermore it is a prerequisite to enable zerocopy on the buffer ports, which can even be a good thing when using opaque buffers. If at some point in time the image_fx component in mmal will be fixed to also support I420 input we may reintroduce them for operating this filter independently from mmal codec and vout.

974e13d mmal/deinterlace: Do not use local buffer pools
modules/hw/mmal/deinterlace.c | 65 ++---------------------------------------
1 file changed, 3 insertions(+), 62 deletions(-)

Upstream: git.videolan.org

  • Share