- For now, this code uses at most as many virtqueues as cpu cores and interrupts are available.
Builder.hxx and DialogController.hxx are included a lot, either directly or indirectly.
Move the implementation to a new source file in the
Check lock availability before acquisition to reduce cache line bouncing.
The multiplication operation is required only if the branch is taken, and the compiler might not optimize it away.
Open the bugdoc, start text edit on the only slide, in the only shape.
Change the virtual weld::IconView::get_rect param from an index/position to a weld::TreeIter and implement that one in the toolkit-specific implementations. For the existing variant taking an index, implement it directly in the weld::IconView base class instead, by converting the index to a iterator and calling the variant taking an iterator. This makes use of the method introduced in previous commit Change-Id: I6c09044ba50556dd57fdc7bce399ba334efeada9 Author: Michael Weghorn Date: Wed Dec 17 16:47:31 2025 +0100 weld: Add method to get ItemView iter for position , see also that commit's commit message for more background. Other methods could be converted/deduplicated in a similar way, e.g.
Introduce weld::ItemView::get_iterator that returns a weld::TreeIter pointing to the item at the given position/index if the position is valid, otherwise a unique_ptr not owning anything. This can be used in upcoming commits to unify the iter-based and index-based methods in the weld::ItemView subclasses (weld::TreeView, weld::IconView) or easily provide both variants without having to implement the whole logic twice in every implementation.
This is the implementation for the abstract weld::ItemView class introduced in
- Reverted some recent changes in FreeBSD for 80211 API changes on their side: - reverted ratectl API use in ieee80211_ratectl_tx_update() - crypto API change (git 5431dafdb9659fb578f) - seqno offload (git cce278510a820785d88) - ni->ni_txrate references use (git 7067450010931479f8) - Re-ported the firmware loading code from OpenBSD.
Change-Id: I1f090d5b7cd829ed586b141536e81b4a9673cc53 Reviewed-on:
Move the class out of weld.hxx into its own header, in order to make it easier to keep an overview and to avoid having to recompile ~all UI code when the class is modified.
The next linux 6.19 release will remove support for compat syscalls on s390x with those commits:
- Create a "Display Baseline Grid" menu item, which triggers the rendering of the baseline grid.
If we sort in sheet view and change the value in sheet view, we need to reverse the sort when syncing the value with the default view.
==1914112==ERROR: AddressSanitizer: heap-use-after-free on address 0x619000483688 at pc 0x7f5b10be03c5 bp 0x7fff55e36670 sp 0x7fff55e36668 READ of size 8 at 0x619000483688 thread T0 #0 0x7f5b10be03c4 in std::__shared_count<(__gnu_cxx::_Lock_policy)2>::__shared_count(std::__weak_count<(__gnu_cxx::_Lock_policy)2> const&, std::nothrow_t) /usr/include/c++/10/bits/shared_ptr_base.h:911 #1 0x7f5b1190ecee in std::__shared_ptr<ARDOUR::VCA, (__gnu_cxx::_Lock_policy)2>::__shared_ptr(std::__weak_ptr<ARDOUR::VCA, (__gnu_cxx::_Lock_policy)2> const&, std::nothrow_t) /usr/include/c++/10/bits/shared_ptr_base.h:1382 #2 0x7f5b1190cc3e in std::shared_ptr<ARDOUR::VCA>::shared_ptr(std::weak_ptr<ARDOUR::VCA> const&, std::nothrow_t) /usr/include/c++/10/bits/shared_ptr.h:417 #3 0x7f5b1190aaae in std::weak_ptr<ARDOUR::VCA>::lock() const /usr/include/c++/10/bits/shared_ptr.h:749 #4 0x7f5b118fea7e in ARDOUR::RouteGroup::remove(std::shared_ptr<ARDOUR::Route>) ../libs/ardour/route_group.cc:267 #5 0x7f5b118fde6e in ARDOUR::RouteGroup::remove_when_going_away(std::weak_ptr<ARDOUR::Route>) ../libs/ardour/route_group.cc:223 #6 0x7f5b11912d3d in void std::__invoke_impl<void, void (ARDOUR::RouteGroup::*&)(std::weak_ptr<ARDOUR::Route>), ARDOUR::RouteGroup*&, std::weak_ptr<ARDOUR::Route>&>(std::__invoke_memfun_deref, void (ARDOUR::RouteGroup::*&)(std::weak_ptr<ARDOUR::Route>), ARDOUR::RouteGroup*&, std::weak_ptr<ARDOUR::Route>&) /usr/include/c++/10/bits/invoke.h:73 #7 0x7f5b119128c8 in std::__invoke_result<void (ARDOUR::RouteGroup::*&)(std::weak_ptr<ARDOUR::Route>), ARDOUR::RouteGroup*&, std::weak_ptr<ARDOUR::Route>&>::type std::__invoke<void (ARDOUR::RouteGroup::*&)(std::weak_ptr<ARDOUR::Route>), ARDOUR::RouteGroup*&, std::weak_ptr<ARDOUR::Route>&>(void (ARDOUR::RouteGroup::*&)(std::weak_ptr<ARDOUR::Route>), ARDOUR::RouteGroup*&, std::weak_ptr<ARDOUR::Route>&) /usr/include/c++/10/bits/invoke.h:95 #8 0x7f5b119125bc in void std::_Bind<void (ARDOUR::RouteGroup::*(ARDOUR::RouteGroup*, std::weak_ptr<ARDOUR::Route>))(std::weak_ptr<ARDOUR::Route>)>::__call<void, , 0ul, 1ul>(std::tuple<>&&, std::_Index_tuple<0ul, 1ul>) /usr/include/c++/10/functional:416 #9 0x7f5b11911fdc in void std::_Bind<void (ARDOUR::RouteGroup::*(ARDOUR::RouteGroup*, std::weak_ptr<ARDOUR::Route>))(std::weak_ptr<ARDOUR::Route>)>::operator()<, void>() /usr/include/c++/10/functional:499 #10 0x7f5b11910e79 in void std::__invoke_impl<void, std::_Bind<void (ARDOUR::RouteGroup::*(ARDOUR::RouteGroup*, std::weak_ptr<ARDOUR::Route>))(std::weak_ptr<ARDOUR::Route>)>&>(std::__invoke_other, std::_Bind<void (ARDOUR::RouteGroup::*(ARDOUR::RouteGroup*, std::weak_ptr<ARDOUR::Route>))(std::weak_ptr<ARDOUR::Route>)>&) /usr/include/c++/10/bits/invoke.h:60 #11 0x7f5b1190f187 in std::enable_if<is_invocable_r_v<void, std::_Bind<void (ARDOUR::RouteGroup::*(ARDOUR::RouteGroup*, std::weak_ptr<ARDOUR::Route>))(std::weak_ptr<ARDOUR::Route>)>&>, void>::type std::__invoke_r<void, std::_Bind<void (ARDOUR::RouteGroup::*(ARDOUR::RouteGroup*, std::weak_ptr<ARDOUR::Route>))(std::weak_ptr<ARDOUR::Route>)>&>(std::_Bind<void (ARDOUR::RouteGroup::*(ARDOUR::RouteGroup*, std::weak_ptr<ARDOUR::Route>))(std::weak_ptr<ARDOUR::Route>)>&) /usr/include/c++/10/bits/invoke.h:110 #12 0x7f5b1190d26a in std::_Function_handler<void (), std::_Bind<void (ARDOUR::RouteGroup::*(ARDOUR::RouteGroup*, std::weak_ptr<ARDOUR::Route>))(std::weak_ptr<ARDOUR::Route>)> >::_M_invoke(std::_Any_data const&) /usr/include/c++/10/bits/std_function.h:291 #13 0x558120310619 in std::function<void ()>::operator()() const /usr/include/c++/10/bits/std_function.h:622 #14 0x7f5b10bcb0d6 in PBD::SignalWithCombiner<PBD::OptionalLastValue<void>, void ()>::operator()() ../libs/pbd/pbd/signals.h:508 #15 0x7f5b10bc779b in PBD::Destructible::drop_references() ../libs/pbd/pbd/destructible.h:33 #16 0x7f5b1196700f in ARDOUR::Session::destroy() ../libs/ardour/session.cc:822 #17 0x7f5b11962f93 in ARDOUR::Session::~Session() ../libs/ardour/session.cc:581 #18 0x7f5b119639a9 in ARDOUR::Session::~Session() ../libs/ardour/session.cc:582 #19 0x558120305a92 in close_session ../luasession/luasession.cc:366 #20 0x55812031911c in luabridge::FuncTraits<void (*)(), void (*)()>::call(void (*)(), luabridge::TypeListValues<void>) ../libs/lua/LuaBridge/detail/FuncTraits.h:73 #21 0x5581203151eb in luabridge::CFunc::Call<void (*)(), void>::f(lua_State*) ../libs/lua/LuaBridge/detail/CFunctions.h:244 #22 0x55812035701f in luaD_precall ../libs/lua/lua-5.3.5/ldo.c:434 #23 0x55812038f1bd in luaV_execute ../libs/lua/lua-5.3.5/lvm.c:1136 #24 0x5581203579a8 in luaD_call ../libs/lua/lua-5.3.5/ldo.c:499 #25 0x558120357a80 in luaD_callnoyield ../libs/lua/lua-5.3.5/ldo.c:509 #26 0x558120346f82 in f_call ../libs/lua/lua-5.3.5/lapi.c:943 #27 0x558120354e59 in luaD_rawrunprotected ../libs/lua/lua-5.3.5/ldo.c:142 #28 0x55812035924f in luaD_pcall ../libs/lua/lua-5.3.5/ldo.c:729 #29 0x558120347226 in lua_pcallk ../libs/lua/lua-5.3.5/lapi.c:969 #30 0x558120393ae9 in LuaState::do_command(std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> >) ../libs/lua/luastate.cc:64 #31 0x558120306da8 in interactive_interpreter ../luasession/luasession.cc:514 #32 0x558120307b36 in main ../luasession/luasession.cc:641 #33 0x7f5b0e40dd79 in __libc_start_main ../csu/libc-start.c:308 #34 0x558120303179 in _start (/home/rgareus/src/ardour/build/luasession/luasession+0x7a179)
We store the sort order of the default view in SheetViewManager, so we can reverse the sort when the sheet view is changed. Tested scenarios are when the auto-filter is sorted in the default view, and the sheet view is changed.
Use the new API introduced in previous commit
- external/python3/decimal.patch.1 partially reverts commit 849e0716d378d6f9f724d1b3c386f6613d52a49d Author: Zachary Ware Date: Mon Mar 18 12:07:25 2024 -0500
Removes the "NetAccess" and "Security" configuration properties from the Office.Java schema. Also removes the corresponding logic in stoc/source/javavm/javavm.cxx that read these properties to configure the JVM appletviewer mode.
The aim is to allow user/view specific locale/language but we are not there yet.
Change-Id: I18e7d840f66287ba5d4c98e2a357b8c72ef072f2 Reviewed-on:
Mainly useful for debugging and to see the content with develop.
Some UI controls should not receive focus on the client side.
To improve decorrelation between components, we offset the dither matrix slightly for each component.
On the surface, this trades a tiny bit of PSNR for not introducing chroma noise into grayscale images.
S12M_TIMECOD --> S12M_TIMECODE Old version is marked deprecated.