Featured content is also available via:

[AArch64] Recognize a missed usage of a sbfiz instruction

22 May 18:35 - GCC - luisgpm

A customer reported the following missed opportunities to combine a couple instructions into a sbfiz. int sbfiz32 (int x) { return x << 29 >> 10; } long sbfiz64 (long x) { return x << 58 >> 20; } This gets converted to the following pattern: (set (reg:SI 98) (ashift:SI (sign_extend:SI (reg:HI 0 x0 [ xD.3334 ])) (const_int 6 [0x6]))) Currently, gcc generates the following: sbfiz32: lsl x0, x0, 29 asr x0, x0, 10 ret sbfiz64: lsl x0, x0, 58 asr x0, x0, 20 ret It could generate this instead: sbfiz32: sbfiz w0, w0, 19, 3 ret sbfiz64:: sbfiz x0, x0, 38, 6 ret The unsigned versions already generate ubfiz for the same code, so the lack of a sbfiz pattern may have been an oversight. This particular sbfiz pattern shows up in both CPU2006 (~ 80 hits) and CPU2017 (~ 280 hits).

i965: Emit VF cache invalidates for 48-bit addressing bugs with softpin

22 May 17:02 - Mesa - Kenneth Graunke

We'd like to start using soft-pin to assign BO addresses up front, and never move them again.

i965: Introduce a "memory zone" concept on BO allocation

22 May 17:01 - Mesa - Kenneth Graunke

We're planning to start managing the PPGTT in userspace in the near future, rather than relying on the kernel to assign addresses.

Meson: Fix cocoa and carbon support

22 May 15:51 - GLib - Xavier Claessens

- Compiler checks were failing because it were using C compiler to build objc code. - xdgmime is needed on osx too. - -DGIO_COMPILATION must be passed to objc compiler too. - gapplication doesn't build on osx, it is excluded in autotools too. We have to be careful when we use add_project_link_arguments(): All targets are built using link arguments for the C language, except for libgio on osx which use the objc language, because it contains some ".m" source files.

Make llseek a compat symbol (bug 18471).

22 May 15:44 - glibc - Joseph Myers

The llseek function name is an obsolete, Linux-specific, unprototyped name for lseek64 with a link-time warning.

[AArch64] Merge stores of D-register values with different modes

22 May 15:35 - GCC - ktkachov

This patch merges loads and stores from D-registers that are of different modes. Code like this: typedef int __attribute__((vector_size(8))) vec; struct pair { vec v; double d; } Now generates a store pair instruction: void assign (struct pair *p, vec v) { p->v = v; p->d = 1.0; } Whereas previously it generated two `str` instructions. This patch also merges storing of double zero values with long integer values: struct pair { long long l; double d; } void foo (struct pair *p) { p->l = 10; p->d = 0.0; } Now generates a single store pair instruction rather than two `str` instructions. The patch basically generalises the mode iterators on the patterns in aarch64.md and the peepholes in aarch64-ldpstp.md to take all combinations of pairs of modes so, while it may be a large-ish patch, it does fairly mechanical stuff. 2018-05-22 Jackson Woodruff Kyrylo Tkachov - config/aarch64/aarch64.md: New patterns to generate stp and ldp.

Open template read-only

22 May 15:17 - LibreOffice - Tor Lillqvist

Otherwise when creating a new docuent based on a template, the template document file is opened read-write eventually (after first being opened read-only five times, and closed again...).

radv: add support for 32-bit pointers in user data SGPRs

22 May 13:53 - Mesa - Samuel Pitoiset

We still use 64-bit GPU pointers for all ring buffers because llvm.amdgcn.implicit.buffer.ptr doesn't seem to support 32-bit GPU pointers for now.

[Ada] In-place initialization for Initialize_Scalars

22 May 13:26 - GCC - pmderodat

This patch optimizes the initialization and allocation of scalar array objects when pragma Initialize_Scalars is in effect.

[Ada] Ada2020: Reduction expressions

22 May 13:25 - GCC - pmderodat

This patch dismantles the prototype implementation of the first proposal for Reduction expressions, one of the important potentially parallel constructs for Ada2020.

[Ada] Spurious visibility error in a nested instance with formal package

22 May 13:23 - GCC - pmderodat

This patch fixes a spurious visibility error with a nested instance of a generic unit with a formal package, when the actual for it is a formal package PA of an enclosing generic, and there are subsequent uses of the formals of PA in that generic unit. 2018-05-22 Ed Schonberg gcc/ada/ - einfo.ads, einfo.adb: New attribute Hidden_In_Formal_Instance, defined on packages that are actuals for formal packages, in order to set/reset the visibility of the formals of a formal package with given actuals, when there are subsequent uses of those formals in the enclosing generic, as required by RN 12.7 (10). - atree.ads, atree.adb: Add operations for Elist30. - atree.h: Add Elist30. - sem_ch12.adb (Analyze_Formal_Package_Instantiation): Collect formals that are not defaulted and are thus not visible within the current instance.

[Ada] Allow attribute 'Valid_Scalars on private types

22 May 13:23 - GCC - pmderodat

This patch modifies the analysis and expansion of attribute 'Valid_Scalars.

[Ada] Spurious visibility error on aspect in generic unit

22 May 13:22 - GCC - pmderodat

This patch fixes a spurious visiblity error on an instantiation of a generic package that contains a type declaration with an aspect specification for an aspect that must be delayed (i.e.

[Ada] Adding support for Ada.Locales package

22 May 13:19 - GCC - pmderodat

This patch adds generic support for the Ada.Locales package that relies on the setlocale() C service.

TextShape: When autoresizing descents are cut, so add a little to the height

22 May 13:14 - Calligra - Dag Andersen

This is a temporary workaround and should be fixed elsewhere, but I don't quite know where.

* MAINTAINERS (loop-optimizer): Add myself

22 May 08:26 - GCC - amker

tdf#83877 Add valid/invalid images to signatures

22 May 07:43 - LibreOffice - Samuel Mehrbrodt

Change-Id: I958c1bad2f32383ebaaeb7d42c761f0d1dfefc35 Reviewed-on:

Documentation: Update doxygen config files

22 May 07:27 - Coreboot - Martin Roth

- Update the config files to 1.8.13- Unify the coreboot and coreboot_simple configs.

soc/nvidia/tegra(124|210): Add distclean targets

22 May 07:25 - Coreboot - Martin Roth

Add distclean targets so these can be called by the junit.xml test target needed for jenkins testing.

[truetype] Reject elements of composites with invalid glyph indices

22 May 07:06 - FreeType - Werner Lemberg

Reported as

Bin dead code

22 May 06:52 - LibreOffice - Tor Lillqvist

OleServer::provideService() was not called anywhere.

Prepare 3.29.2

22 May 05:28 - Epiphany - Michael Catanzaro

Fix svg to base64 conversion

22 May 04:56 - LibreOffice - Samuel Mehrbrodt

This reverts part of ab14a9708d2937bc767c14542610ce91b56dda1e which had a questionable fix by unconditionally removing the first 8 bytes of the svg which led to svgs starting with

Don't pass ODF version, just retrieve it directly

22 May 04:55 - LibreOffice - Samuel Mehrbrodt

Change-Id: I19ff42c348515b17dac17abe750ee03ca53efcbf Reviewed-on:

powerpc/64s: Add support for a store forwarding barrier at kernel entry/exit

22 May 03:45 - Linux Kernel - Nicholas Piggin

On some CPUs we can prevent a vulnerability related to store-to-load forwarding by preventing store forwarding between privilege domains, by inserting a barrier in kernel entry and exit paths.

rk3399: Enable bootblock compression

22 May 02:44 - Coreboot - Julius Werner

This patch enables the new bootblock compression feature on RK3399, which requires moving MMU initialization into the decompressor stage and linking the decompressor (rather than the bootblock) into the entry point jumped to by the masked ROM. RK3399's masked ROM seems to be using a bitbang SPI driver to load us (very long pauses between clocking in each byte), with an effective data rate of about 1Mbit.

Introduce bootblock self-decompression

22 May 02:44 - Coreboot - Julius Werner

Masked ROMs are the silent killers of boot speed on devices without memory-mapped SPI flash.

cbfs-compression-tool: Add raw compression support

22 May 02:38 - Coreboot - Julius Werner

This patch adds a new "rawcompress" command to cbfs-compression-tool, that works exactly the same as "compress" except that it doesn't add the custom 8-byte header to the file.

i965/glk: Add l3 banks count for 2x6 configuration

21 May 23:43 - Mesa - Anuj Phogat

2x6 configuration with pci-id 0x3185 has same number of banks (2) as 3x6 configuration (pci-id 0x3184).

[gcc] 2018-05-21 Michael Meissner

21 May 22:21 - GCC - meissner

[gcc] 2018-05-21 Michael Meissner <meissner@linux.ibm.com> PR target/85657 - config/rs6000/rs6000-c.c (rs6000_cpu_cpp_builtins): Do not define __ibm128 as long double. - config/rs6000/rs6000.c (rs6000_init_builtins): Always create __ibm128 as a distinct type.

dwrite: Support IDWriteFontList1 for font families

21 May 22:05 - WINE - Nikolay Sivov

uitest - Calc standard filter

21 May 19:44 - LibreOffice - Zdeněk Crhonek

Change-Id: I578e0fa94326677ce277cd24e043c699d152a5dd Reviewed-on:

Activated notebookbar in draw

21 May 18:58 - LibreOffice - Kshitij Pathania

Added tabbed and two groupedbars mode of notebookbar.

wined3d: Implement YUV blits in the GLSL blitter

21 May 18:34 - WINE - Matteo Bruni

Merge branch 'speck-v20' of git://git.kernel.org/pub/scm/linux/kernel/git/tip/tip

21 May 18:23 - Linux Kernel - Linus Torvalds

Initial Fast Short REP MOVSB (FSRM) support

21 May 17:54 - glibc - H.J. Lu

The newer Intel processors support Fast Short REP MOVSB which has a feature bit in CPUID.

mb/google/octopus: Add devicetree for Bip

21 May 17:40 - Coreboot - Justin TerAvest

Bip should have different devicetree entries than Yorp; it doesn't have a DA7219 audio codec (instead it uses ALC5682).

Add support for opening file streams from wide character strings

21 May 17:18 - GCC - redi

C++17 added new overloads to <fstream> class templates to support opening files from wide character strings "on systems where filesystem::path::value_type is not char".

[Ada] Aspects on stubs

21 May 14:52 - GCC - pmderodat

This patch ensures that aspect specifications which appear on package, protected, and task body stubs are properly analyzed. -- Source -- -- pack.ads package Pack with SPARK_Mode, Abstract_State => State is -- Refined_Depends, Refined_Global -- procedure Proc_1; procedure Proc_2 with Global => (In_Out => State), Depends => (State => State); task Task_Obj_1; task Task_Obj_2 with Global => (In_Out => State), Depends => (State => State); -- Refined_Post -- function Func_1 (Formal : Integer) return Integer; function Func_2 (Formal : Integer) return Integer with Post => Func_2'Result > Formal; -- Refined_State -- package Pack_1 is end Pack_1; package Pack_2 with Abstract_State => State_2 is end Pack_2; -- SPARK_Mode -- package Pack_3 with SPARK_Mode => Off is end Pack_3; package Pack_4 with SPARK_Mode => Off is end Pack_4; package Pack_5 is end Pack_5; protected type Prot_Typ_1 with SPARK_Mode => Off is end Prot_Typ_1; protected type Prot_Typ_2 with SPARK_Mode => Off is end Prot_Typ_2; protected type Prot_Typ_3 is end Prot_Typ_3; procedure Proc_3 with SPARK_Mode => Off; procedure Proc_4 with SPARK_Mode => Off; procedure Proc_5; task type Task_Typ_1 with SPARK_Mode => Off; task type Task_Typ_2 with SPARK_Mode => Off; task type Task_Typ_3; end Pack; -- pack.adb package body Pack with SPARK_Mode, Refined_State => (State => Constit) is Constit : Integer := 0; -- Refined_Depends, Refined_Global -- procedure Proc_1 is separate with Refined_Global => (In_Out => Constit), -- Error Refined_Depends => (Constit => Constit); -- Error procedure Proc_2 is separate with Refined_Global => (In_Out => Constit), -- OK Refined_Depends => (Constit => Constit); -- OK task body Task_Obj_1 is separate with Refined_Global => (In_Out => Constit), -- Error Refined_Depends => (Constit => Constit); -- Error task body Task_Obj_2 is separate with Refined_Global => (In_Out => Constit), -- OK Refined_Depends => (Constit => Constit); -- OK -- Refined_Post -- function Func_1 (Formal : Integer) return Integer is separate with Refined_Post => Func_1'Result > Formal; -- OK function Func_2 (Formal : Integer) return Integer is separate with Refined_Post => Func_2'Result > Formal; -- OK -- Refined_State -- package body Pack_1 is separate with Refined_State => (State_1 => Constit_1); -- Error package body Pack_2 is separate with Refined_State => (State_2 => Constit_2); -- Error -- SPARK_Mode -- package body Pack_3 is separate with SPARK_Mode => On; -- Error package body Pack_4 is separate; package body Pack_5 is separate with SPARK_Mode => Off; -- Error protected body Prot_Typ_1 is separate with SPARK_Mode => On; -- Error protected body Prot_Typ_2 is separate; protected body Prot_Typ_3 is separate with SPARK_Mode => Off; -- Error procedure Proc_3 is separate with SPARK_Mode => On; -- Error procedure Proc_4 is separate; procedure Proc_5 is separate with SPARK_Mode => Off; -- Error task body Task_Typ_1 is separate with SPARK_Mode => On; -- Error task body Task_Typ_2 is separate; task body Task_Typ_3 is separate with SPARK_Mode => Off; -- Error end Pack; -- pack-func_1.adb separate (Pack) function Func_1 (Formal : Integer) return Integer with Refined_Post => Func_1'Result > Formal -- Error is begin return Formal * 10; end Func_1; -- pack-func_2.adb separate (Pack) function Func_2 (Formal : Integer) return Integer with Refined_Post => Func_2'Result > Formal -- Error is begin return Formal * 10; end Func_2; -- pack-pack_1.adb separate (Pack) package body Pack_1 with SPARK_Mode, Refined_State => (State_1 => Constit_1) -- Error is Constit_1 : Integer := 1; end Pack_1; -- pack-pack_2.adb separate (Pack) package body Pack_2 with SPARK_Mode, Refined_State => (State_2 => Constit_2) -- OK is Constit_2 : Integer := 2; end Pack_2; -- pack-pack_3.adb separate (Pack) package body Pack_3 is end Pack_3; -- pack-pack_4.adb separate (Pack) package body Pack_4 with SPARK_Mode => On is end Pack_4; -- OK -- pack-pack_5.adb separate (Pack) package body Pack_5 with SPARK_Mode => On is end Pack_5; -- OK -- pack-proc_1.adb separate (Pack) procedure Proc_1 with Refined_Global => (In_Out => Constit), -- Error Refined_Depends => (Constit => Constit) -- Error is begin null; end Proc_1; -- pack-proc_2.adb separate (Pack) procedure Proc_2 with Refined_Global => (In_Out => Constit), -- Error Refined_Depends => (Constit => Constit) -- Error is begin null; end Proc_2; -- pack-proc_3.adb separate (Pack) procedure Proc_3 is begin null; end Proc_3; -- pack-proc_4.adb separate (Pack) procedure Proc_4 with SPARK_Mode => On is begin null; end Proc_4; -- OK -- pack-proc_5.adb separate (Pack) procedure Proc_5 with SPARK_Mode => On is begin null; end Proc_5; -- OK -- pack-prot_typ_1.adb separate (Pack) protected body Prot_Typ_1 is end Prot_Typ_1; -- pack-prot_typ_2.adb separate (Pack) protected body Prot_Typ_2 with SPARK_Mode => On is end Prot_Typ_2; -- OK -- pack-prot_typ_3.adb separate (Pack) protected body Prot_Typ_3 with SPARK_Mode => On is end Prot_Typ_3; -- OK -- pack-task_obj_1.adb separate (Pack) task body Task_Obj_1 with Refined_Global => (In_Out => Constit), -- Error Refined_Depends => (Constit => Constit) -- Error is begin null; end Task_Obj_1; -- pack-task_obj_2.adb separate (Pack) task body Task_Obj_2 with Refined_Global => (In_Out => Constit), -- Error Refined_Depends => (Constit => Constit) -- Error is begin null; end Task_Obj_2; -- pack-task_typ_1.adb separate (Pack) task body Task_Typ_1 is begin null; end Task_Typ_1; -- pack-task_typ_2.adb separate (Pack) task body Task_Typ_2 with SPARK_Mode => On is -- OK begin null; end Task_Typ_2; -- pack-task_typ_3.adb separate (Pack) task body Task_Typ_3 with SPARK_Mode => On is -- OK begin null; end Task_Typ_3; -- Compilation and output -- $ gcc -c pack.adb pack.adb:12:11: useless refinement, declaration of subprogram "Proc_1" lacks aspect or pragma Global pack.adb:13:11: useless refinement, declaration of subprogram "Proc_1" lacks aspect or pragma Depends pack.adb:20:11: useless refinement, declaration of task type "Task_Obj_1" lacks aspect or pragma Global pack.adb:21:11: useless refinement, declaration of task type "Task_Obj_1" lacks aspect or pragma Depends pack.adb:42:11: aspect "Refined_State" must apply to a package body pack.adb:45:11: aspect "Refined_State" must apply to a package body pack.adb:51:41: incorrect placement of aspect "Spark_Mode" pack.adb:53:41: incorrect placement of aspect "Spark_Mode" pack.adb:55:47: incorrect placement of aspect "Spark_Mode" pack.adb:57:47: incorrect placement of aspect "Spark_Mode" pack.adb:59:38: incorrect placement of aspect "Spark_Mode" pack.adb:61:38: incorrect placement of aspect "Spark_Mode" pack.adb:63:42: incorrect placement of aspect "Spark_Mode" pack.adb:65:42: incorrect placement of aspect "Spark_Mode" pack-proc_1.adb:4:08: aspect "Refined_Global" cannot apply to a subunit pack-proc_1.adb:5:08: aspect "Refined_Depends" cannot apply to a subunit pack-proc_2.adb:4:08: aspect "Refined_Global" cannot apply to a subunit pack-proc_2.adb:5:08: aspect "Refined_Depends" cannot apply to a subunit pack-task_obj_1.adb:4:08: aspect "Refined_Global" cannot apply to a subunit pack-task_obj_1.adb:5:08: aspect "Refined_Depends" cannot apply to a subunit pack-task_obj_2.adb:4:08: aspect "Refined_Global" cannot apply to a subunit pack-task_obj_2.adb:5:08: aspect "Refined_Depends" cannot apply to a subunit pack-func_1.adb:4:08: aspect "Refined_Post" cannot apply to a subunit pack-func_2.adb:4:08: aspect "Refined_Post" cannot apply to a subunit pack-pack_1.adb:3:14: body of package "Pack_1" has unused hidden states pack-pack_1.adb:3:14: variable "Constit_1" defined at line 7 pack-pack_1.adb:5:08: useless refinement, package "Pack_1" does not define abstract states pack-pack_1.adb:5:26: "State_1" is undefined pack-pack_3.adb:3:01: incorrect use of SPARK_Mode at pack.adb:2 pack-pack_3.adb:3:01: value Off was set for SPARK_Mode on "Pack_3" at pack.ads:38 pack-pack_4.adb:3:01: incorrect use of SPARK_Mode at pack.adb:2 pack-pack_4.adb:3:01: value Off was set for SPARK_Mode on "Pack_4" at pack.ads:39 pack-pack_4.adb:3:26: incorrect use of SPARK_Mode pack-pack_4.adb:3:26: value Off was set for SPARK_Mode on "Pack_4" at pack.ads:39 pack-prot_typ_2.adb:3:32: incorrect use of SPARK_Mode pack-prot_typ_2.adb:3:32: value Off was set for SPARK_Mode on "Prot_Typ_2" at pack.ads:43 pack-proc_3.adb:3:01: incorrect use of SPARK_Mode at pack.adb:2 pack-proc_3.adb:3:01: value Off was set for SPARK_Mode on "Proc_3" at pack.ads:46 pack-proc_4.adb:3:01: incorrect use of SPARK_Mode at pack.adb:2 pack-proc_4.adb:3:01: value Off was set for SPARK_Mode on "Proc_4" at pack.ads:47 pack-proc_4.adb:3:23: incorrect use of SPARK_Mode pack-proc_4.adb:3:23: value Off was set for SPARK_Mode on "Proc_4" at pack.ads:47 pack-task_typ_2.adb:3:27: incorrect use of SPARK_Mode pack-task_typ_2.adb:3:27: value Off was set for SPARK_Mode on "Task_Typ_2" at pack.ads:51 2018-05-21 Hristian Kirtchev gcc/ada/ - sem_ch6.adb (Analyze_Generic_Subprogram_Body): Rename the call to Analyze_Aspect_Specifications_On_Body_Or_Stub.

[Ada] Spurious error on early call region of tagged type

21 May 14:52 - GCC - pmderodat

This patch corrects the part of the access-before-elaboration mechanism which ensures that the freeze node of a tagged type is within the early call region of all its overriding bodies to ignore predefined primitives. -- Source -- -- pack.ads package Pack with SPARK_Mode is type Parent_Typ is tagged null record; procedure Prim (Obj : Parent_Typ); type Deriv_Typ is new Parent_Typ with private; overriding procedure Prim (Obj : Deriv_Typ); private type Deriv_Typ is new Parent_Typ with null record; end Pack; -- Compilation -- $ gcc -c pack.ads 2018-05-21 Hristian Kirtchev gcc/ada/ - exp_cg.adb: Remove with and use clause for Exp_Disp. - exp_ch9.adb: Remove with and use clause for Exp_Disp. - exp_disp.adb (Is_Predefined_Dispatching_Operation): Moved to Sem_Util.

[Ada] Placement of pragma Elaboration_Checks

21 May 14:51 - GCC - pmderodat

This patch modifies the semantics of pragma Elaboration_Checks.

[Ada] Premature secondary stack reclamation

21 May 14:49 - GCC - pmderodat

This patch modifies the creation of transient scopes to eliminate potential premature secondary stack reclamations when there is no suitable transient context and the scope was intended to manage the secondary stack.

util/testing: Update junit.xml to support coreboot builds

21 May 13:17 - Coreboot - Martin Roth

Up to this point, junit.xml has only been used to build tools, as abuild has handled the coreboot builds.

[ARC] Add multilib support for linux targets

21 May 09:56 - GCC - claziss

We used to build baremetal (AKA Elf32) multilibbed toolchains for years now but never made that for Linux targets since there were problems with uClibc n multilib setup.

radv: Fix SRGB compute copies

21 May 08:33 - Mesa - Bas Nieuwenhuizen

SRGB stores are broken.

client/gatt : Add support for Included Service

21 May 08:30 - BlueZ - Avichal Agarwal

mesa: stop hiding query parameters from OpenGL compat

20 May 23:39 - Mesa - Timothy Arceri

Just let the extension detection do its job as we will be adding compat profile support in future, also we want these to work with compat profile version overrides.

Linux 4.17-rc6

20 May 22:31 - Linux Kernel - Linus Torvalds

* include/freetype/ftcolor.h: New file

20 May 20:50 - FreeType - Werner Lemberg

This is an interface to the `CPAL' OpenType table.

Documentation: Add lesson1 from the wiki

20 May 19:12 - Coreboot - Martin Roth

Convert the lesson1 document from the wiki to markdown, update it for Ubuntu 18.04, and extend it slightly with new information.

Merge branch 'x86-urgent-for-linus' of git://git.kernel.org/pub/scm/linux/kernel/git/tip/tip

20 May 18:28 - Linux Kernel - Linus Torvalds

tdf#35798: Hide empty Database fields' paragraphs (+ compat option)

20 May 11:16 - LibreOffice - Mike Kaganski

With this change, Database fields that expand to empty values behave as if they are "Hidden Paragraph" fields. A compatibility option to enable this behaviour is added.

[NDS32] Rewrite cost model

20 May 07:23 - GCC - jasonwucj

gcc/ - config/nds32/nds32-cost.c (rtx_cost_model_t): New structure.

tdf#117502 fix graphical bullets for OOXML and RTF

20 May 03:18 - LibreOffice - Tomaž Vajngerl

This change has multiple parts:- Move "BulletAsImage" test from ODT only to globalfilter and run it on ODT, DOC, DOCX, RTF formats and extend checks of the XGraphic used for the bullets and the size.- Check if GIF is animated as we need to know this in unloaded graphic or bullets aren't rendered correctly if we assume they are animated.- Use "Graphic" property in writerfilter to get the graphic from a XShape and not the "Bitmap" property which returns a Graphic as a MetaFile and not the original Graphic.- Make sure "GraphicBitmap" is filled with XBitmap and not with XGraphic.- Change "testFDO74215" to use the expected bullet size as it is in the original document.