CBMEM console: Fix and enhance pre-RAM support

Hardware / Coreboot - Kyösti Mälkki [gmail.com] - 27 January 2015 15:44 UTC

Use the value of CONSOLE_PRERAM_BUFFER_SIZE to determine if we can do CBMEM console in bootblock and romstage. Kconfig forces it to zero if _BASE is unset or we cannot do CAR migration on x86.

Add CBMEM console to bootblock, except for x86. Only one of bootblock and romstage clears the pre-RAM buffer.

To start with empty console log on S3 wakeup, ramstage now clears previous contents of CBMEM buffer if there was no pre-RAM buffer.

Unify Kconfig variable naming.

TODO: ARM configurations do not define PRERAM_BUFFER_BASE values.

Change-Id: I70d82da629529dbfd7bc9491223abd703cbc0115

8659e40 CBMEM console: Fix and enhance pre-RAM support
src/arch/arm/Kconfig | 4 --
src/arch/arm/bootblock.ld | 4 +-
src/arch/arm/romstage.ld | 2 +-
src/arch/arm64/bootblock.ld | 2 +
src/arch/arm64/romstage.ld | 2 +-
src/arch/riscv/romstage.ld | 2 +-
src/console/Kconfig | 14 ++++--
src/include/console/cbmem_console.h | 3 +-
src/lib/Makefile.inc | 1 +
src/lib/cbmem_console.c | 80 ++++++++++++++++++++---------------
10 files changed, 66 insertions(+), 48 deletions(-)

Upstream: review.coreboot.org


  • Share