ec/lenovo/h8: Add USB Always On

Hardware / Coreboot - Nicola Corna [corna.info] - 18 November 2016 11:14 UTC

USB AO is the internal name for the dedicated charging port on ThinkPads when in S3 or lower.

AOEN (bit 0) is internal name for enabling this feature while AOCF (bits 2 and 3) is the configuration field. According to Peter Stuge, AOCF can be configured in this way:

00 => AC S3 S4 S4 USB on, battery S3 USB on, battery S4 S5 off 11 => AC S3 S4 S4 USB on, battery S3 S4 S5 USB off 10, 01 => equivalent to 00

This commit also adds a new configuration field in the CMOS of the X220 and the X201 to activate this feature. It probably can be also added to all the ThinkPads that support this functionality.

With this functionality USB devices are able to negotiate full power from the dedicated port (usually the yellow one) even in S3.

Tested on a X201 and X220 with an Android smartphone: with this feature enabled it shows "Charging" when connected during S3, without it it shows "Charging slowly" (or it doesn't charge at all on the X201).

For some reasons the "AC only" mode doesn't work, so it has been disabled.

Change-Id: Ie1269a4357e2fbd608ad8b7b8262275914730f6e

f1395d8 ec/lenovo/h8: Add USB Always On
src/ec/lenovo/h8/Makefile.inc | 1 +
src/ec/lenovo/h8/h8.c | 2 ++
src/ec/lenovo/h8/h8.h | 5 +++++
src/ec/lenovo/h8/smm.c | 35 ++++++++++++++++++++++++++++++++
src/mainboard/lenovo/x201/cmos.default | 1 +
src/mainboard/lenovo/x201/cmos.layout | 6 ++++--
src/mainboard/lenovo/x201/smihandler.c | 2 ++
src/mainboard/lenovo/x220/cmos.default | 1 +
src/mainboard/lenovo/x220/cmos.layout | 5 ++++-
src/mainboard/lenovo/x220/smihandler.c | 2 ++
10 files changed, 57 insertions(+), 3 deletions(-)

Upstream: review.coreboot.org


  • Share