fsp_Broadwell_DE: Do not set IRQ3 and IRQ4 to level

Hardware / Coreboot - Kevin Paul Herbert [trippers.org] - 11 August 2016 08:16 UTC

When booting Linux as a coreboot payload, serial access does not work properly. This is because the setup code erroneously sets IRQ3 and IRQ4 to level. The UART on Broadwell is 8250/16550 compatible, thus ISA and edge-triggered.

This change is not necessary on the non-FSP version of Broadwell support. The non-FSP version does not set these IRQ overrides.

Fix verified booting Linux 4.6.0-rc2 on Intel Camelback Mountain CRB, using Intel FSP 1.0.

Change-Id: I17b466676e7f4891c3e75ce6208e1580c9eaf742

d7127b0 fsp_Broadwell_DE: Do not set IRQ3 and IRQ4 to level
src/soc/intel/fsp_broadwell_de/acpi.c | 10 ----------
1 file changed, 10 deletions(-)

Upstream: review.coreboot.org

  • Share