fsp platfoms: add prototype & consolidate main entry-point

Hardware / Coreboot - Martin Roth [se-eng.com] - 8 December 2014 20:02 UTC

- In '-ffreestanding' main() is just as any other function and so it needs a type-signature. Fixes a clang warning.

- Bay Trail and Rangeley have the updated romstage.c with the code moved into the chipset, put the prototype in romstage.c.

- The sandybridge code has not been updated, so the prototype for it goes into chipset_fsp_util.h, next to the prototype for romstage_main_continue.

- Correct the return value of baytrail main() from void * to void and remove the unnecessary asmlinkage tag. I'm surprised that this didn't generate a warning...

Change-Id: I85ac0797d1e55d2b7ffdca039a52820d7827e704

a0a71b0 fsp platfoms: add prototype & consolidate main entry-point
src/mainboard/intel/cougar_canyon2/romstage.c | 1 -
.../intel/fsp_sandybridge/fsp/chipset_fsp_util.h | 3 +++
src/soc/intel/fsp_baytrail/baytrail/romstage.h | 4 ++--
src/soc/intel/fsp_baytrail/romstage/romstage.c | 2 +-
src/southbridge/intel/fsp_rangeley/romstage.h | 4 ++--
5 files changed, 8 insertions(+), 6 deletions(-)

Upstream: review.coreboot.org

  • Share