hp/pavilion_m6_1035dx: Add SMI handler and handle EC requests

Hardware / Coreboot - Alexandru Gagniuc [gmail.com] - 17 April 2014 09:48 UTC

The EC may disable some functionality, such as Caps Lock LED and battery charging if it never receives a command to go in APM mode. If we start it in APM mode, then immediately switch to ACPI mode, it will not get its SCIs serviced until an ACPI OS boots. If its SCIs are not serviced, it may assume the OS has hung.

The way we solve this is to initalize the EC in APM mode, and only switch it to ACPI when an ACPI-capable OS issues the ACPI_ENABLE command. The switch has to be handled in SMM.

Although we aren't yet processing SMIs from the EC, we are reading the status in order to satisfy the EC that the event is handled.

Change-Id: Iffaeb9a6f57841f456c4bce8337dc09b287f8758

73639e2 hp/pavilion_m6_1035dx: Add SMI handler and handle EC requests
src/mainboard/hp/pavilion_m6_1035dx/Kconfig | 1 +
src/mainboard/hp/pavilion_m6_1035dx/Makefile.inc | 2 +
src/mainboard/hp/pavilion_m6_1035dx/ec.c | 18 +++--
src/mainboard/hp/pavilion_m6_1035dx/ec.h | 4 +
src/mainboard/hp/pavilion_m6_1035dx/mainboard.c | 5 ++
.../hp/pavilion_m6_1035dx/mainboard_smi.c | 77 ++++++++++++++++++++
6 files changed, 102 insertions(+), 5 deletions(-)

Upstream: review.coreboot.org


  • Share