libpayload: Introduce new Kconfig to explicitly allow GPL code

Hardware / Coreboot - Julius Werner [chromium.org] - 9 January 2015 00:06 UTC

There have been leaks of GPL code into libpayload for a while now, for new features or improvements that require third party code with no adequate alternative among BSD-licensed software. It seems silly and counter-productive to keep holding back features and performance improvements from libpayload for a use-case (proprietary payloads) that doesn't even seem to be implemented anywhere to date. Open-source payloads should not need to suffer to appease commercial ones.

Instead, this patch introduces a new Kconfig option to explicitly allow inclusion of GPL code. It will use Kconfig dependencies and/or Makefile rules to ensure that no GPL code can end up in the final payload if that option is unset, allowing proprietary payloads to keep working with the existing BSD-licensed feature set. New features and patches (that are sufficiently separate and self-contained to allow guarding through this config option) can choose whether to import GPL code, and need to depend on this option if they do.

Also clean up all (known) existing uses of GPL code to depend on the new option, add some recent third-party imports to the LICENSES file, and relicense the selfboot.c files to BSD with permission of the author.

BUG=chrome-os-partner:24957 TEST=Compiled Falco and Nyan_Big both with and without the new option, disassembled output binaries to ensure that memcpy() looks as expected.

Original-Change-Id: I6e3a75b1a8e46291c75a876844c7a01f7d3f2a0e

22adcd6 libpayload: Introduce new Kconfig to explicitly allow GPL code
payloads/libpayload/Config.in | 9 +
payloads/libpayload/LICENSES | 23 +-
payloads/libpayload/LICENSE_GPL | 345 ++++++++++++++++++++++
payloads/libpayload/arch/arm/Makefile.inc | 5 +-
payloads/libpayload/arch/arm/selfboot.c | 37 ++-
payloads/libpayload/arch/x86/Makefile.inc | 5 +-
payloads/libpayload/arch/x86/selfboot.c | 38 ++-
payloads/libpayload/configs/config.arm64-generic | 3 +-
payloads/libpayload/configs/defconfig | 1 +
payloads/libpayload/configs/defconfig-arm | 3 +-
10 files changed, 432 insertions(+), 37 deletions(-)

Upstream: review.coreboot.org

  • Share