elm - elm image orientation api fix - major bug in implementation

Desktop / Enlightenment / Elementary - Carsten Haitzler (Rasterman) [rasterman.com] - 11 January 2015 20:31 UTC

@fix

The elm image orient_set api looks like it is a state, and it is documented to SET the orietnation, but the code actually DOEs that orientation when you set it. so docs and api name didnt match functionality at all. this was bad an an oversight. you didn't notice until you set orientation multiple times to an image. this fixes the implementation to be as documented - a state that is applied and remains that way until set to something else. setting to the same orientation has no efect as with color, size, etc. etc. in evas.

you could look on this as an api break, but then either the docs change AND api name changes to match the code, or code changes to match the docs. we don't keep bug compatibility in efl and in this case i'm making the call to break the behavior of a function as it was broken already with respect to name and docs.

d6f4040 elm - elm image orientation api fix - major bug in implementation
src/lib/elm_image.c | 456 +++++++++++++++++++++++++++-----------------
src/lib/elm_image_common.h | 3 +
2 files changed, 286 insertions(+), 173 deletions(-)

Upstream: git.enlightenment.org

  • Share