bookmarks: Split list model functionality into separate class

Desktop / GNOME / Epiphany - Michael Catanzaro [gnome.org] - 1 November 2016 18:02 UTC

This is much less efficient, but it also makes the code much simpler and more robust. Using EphyBookmarksManager as the list model was a good choice at the time, when we were not thinking about smart bookmarks, but now that we need to handle both it doesn't work so well. My initial implementation was complex and buggy. Simplify this.

feacce2 bookmarks: Split list model functionality into separate class
src/Makefile.am | 2 +
src/bookmarks/ephy-bookmarks-list-model.c | 193 +++++++++++++++++++++++++++++
src/bookmarks/ephy-bookmarks-list-model.h | 36 ++++++
src/bookmarks/ephy-bookmarks-manager.c | 54 +-------
src/bookmarks/ephy-bookmarks-popover.c | 20 ++-
src/ephy-location-controller.c | 2 +
6 files changed, 251 insertions(+), 56 deletions(-)

Upstream: git.gnome.org

  • Share