gdk: Large GL refactoring

Desktop / GNOME / GTK - Benjamin Otte [redhat.com] - 5 December 2016 08:02 UTC

No visible changes as GL rendering is disabled at the moment.

What was done:

1. Move window->invalidate_for_new_frame to glcontext->begin_frame This moves the code to where it is used (the GLContext) and prepares it for being called where it is used when actually beginning to draw the frame.

2. Get rid of buffer-age usage We want to let the application render directly to the backbuffer. Because of that, we cannot make any assumptions about the contents the application renders outside the clip area. In particular GskGLRenderer renders random stuff there but not actual contents.

3. Pass the actual GL context Previously, we passed the shared context to end_frame, now we pass the actual GL context that the application uses for rendering. This is so that the vfuncs could prepare the actual contexts for rendering (they don't currently).

4. Simplify the code The previous code set up the final drawing method in begin_frame. Instead, we now just ensure the clip area is something we can render and decide on the actual method in end_frame. This is both more robust (we can change the clip area in between if we want to) and less code.

182d18b gdk: Large GL refactoring
gdk/gdkglcontextprivate.h | 2 +
gdk/gdkwindow.c | 8 ---
gdk/gdkwindowimpl.h | 2 -
gdk/mir/gdkmirglcontext.c | 20 +++++++
gdk/mir/gdkmirwindowimpl.c | 62 --------------------
gdk/wayland/gdkglcontext-wayland.c | 79 ++++++-------------------
gdk/wayland/gdkglcontext-wayland.h | 2 -
gdk/wayland/gdkwindow-wayland.c | 1 -
gdk/win32/gdkglcontext-win32.c | 104 +++++++++++++++------------------
gdk/win32/gdkglcontext-win32.h | 14 -----
gdk/win32/gdkwindow-win32.c | 1 -
gdk/x11/gdkglcontext-x11.c | 112 +++++++++++-------------------------
gdk/x11/gdkglcontext-x11.h | 4 --
gdk/x11/gdkwindow-x11.c | 1 -
14 files changed, 118 insertions(+), 294 deletions(-)

Upstream: git.gnome.org

  • Share