cli: remove editor thread

System Internals / NetworkManager - Beniamino Galvani [redhat.com] - 23 September 2016 02:46 UTC

Currently the editor runs in a dedicated thread so that the blocking call to readline() doesn't stop the processing of D-Bus events in the main loop. The editor thread can access objects concurrently with the main thread and this can cause races and crashes.

Remove the editor thread and use the non-blocking readline API.

https://bugzilla.gnome.org/show_bug.cgi?id=732097 https://bugzilla.redhat.com/show_bug.cgi?id=1368353

9952291 cli: remove editor thread
clients/cli/common.c | 117 +++++++++++++++++++++-----------------
clients/cli/connections.c | 61 ++------------------
clients/cli/nmcli.c | 137 +++++++++------------------------------------
clients/cli/nmcli.h | 1 +
4 files changed, 97 insertions(+), 219 deletions(-)

Upstream: cgit.freedesktop.org

  • Share