libnm: don't add objects to cache until they're async-inited

System Internals / NetworkManager - Lubomir Rintel [v3.sk] - 15 September 2015 09:53 UTC

Otherwise the uninitializeded objects could be prematurely signalled if their paths are seen twice in quick succession. This happens when you have ethernet hardware and add an ethernet connection -- it's immediatelly added to AvialableConnections and the property reload signals the object addition before the NMRemoteSettings's GetSettings() finishes:

# nmcli c add type ethernet autoconnect no ifname '*' (process:4610): libnm-CRITICAL **: nm_connection_get_id: assertion 's_con != NULL' failed Connection '(null)' ((null)) successfully added. #

https://bugzilla.gnome.org/show_bug.cgi?id=754794

88f0d64 libnm: don't add objects to cache until they're async-inited
libnm/nm-object.c | 6 +++++-
1 file changed, 5 insertions(+), 1 deletion(-)

Upstream: cgit.freedesktop.org

  • Share