libnm: make the the use of GInitable mandatory

System Internals / NetworkManager - Dan Winship [gnome.org] - 1 August 2014 13:34 UTC

Remove _nm_object_ensure_inited(), etc; objects that implement GInitable are now mandatory-to-init().

Remove constructor() implementations that sometimes return NULL; do all the relevant checking in init() instead.

Make nm_client_new() and nm_remote_settings_new() take a GCancellable and a GError**.

258e74e libnm: make the the use of GInitable mandatory
clients/cli/connections.c | 6 +-
clients/cli/network-manager.c | 5 +-
clients/cli/nmcli.c | 7 +-
clients/nm-online.c | 6 +-
clients/tui/nmtui.c | 14 +++-
examples/C/glib/add-connection-libnm.c | 15 ++--
examples/C/glib/get-ap-info-libnm.c | 6 +-
examples/C/glib/list-connections-libnm.c | 10 +--
examples/python/gi/device-state-ip4config.py | 2 +-
examples/python/gi/get-active-connections.py | 2 +-
examples/python/gi/get_ips.py | 2 +-
examples/python/gi/show-wifi-networks.py | 2 +-
libnm-core/nm-setting.c | 17 ++--
libnm/nm-access-point.c | 11 ---
libnm/nm-active-connection.c | 17 ----
libnm/nm-client.c | 91 ++++++--------------
libnm/nm-client.h | 3 +-
libnm/nm-device-adsl.c | 1 -
libnm/nm-device-bond.c | 5 --
libnm/nm-device-bridge.c | 5 --
libnm/nm-device-bt.c | 5 --
libnm/nm-device-ethernet.c | 6 --
libnm/nm-device-generic.c | 4 -
libnm/nm-device-infiniband.c | 4 -
libnm/nm-device-modem.c | 4 -
libnm/nm-device-olpc-mesh.c | 5 --
libnm/nm-device-team.c | 5 --
libnm/nm-device-vlan.c | 5 --
libnm/nm-device-wifi.c | 9 --
libnm/nm-device-wimax.c | 10 ---
libnm/nm-device.c | 23 ------
libnm/nm-dhcp4-config.c | 18 +---
libnm/nm-dhcp6-config.c | 18 +---
libnm/nm-ip4-config.c | 9 --
libnm/nm-ip6-config.c | 10 ---
libnm/nm-object-private.h | 2 -
libnm/nm-object.c | 113 +++++++++++--------------
libnm/nm-remote-connection.c | 62 ++++----------
libnm/nm-remote-settings.c | 115 +++++++-------------------
libnm/nm-remote-settings.h | 7 +-
libnm/nm-vpn-connection.c | 6 --
libnm/nm-vpn-plugin.c | 69 +++++++---------
libnm/nm-wimax-nsp.c | 5 --
libnm/tests/test-remote-settings-client.c | 12 ++-
44 files changed, 225 insertions(+), 528 deletions(-)

Upstream: cgit.freedesktop.org

  • Share