settings: drop plugin-specific error domains

System Internals / NetworkManager - Dan Winship [gnome.org] - 22 October 2014 07:29 UTC

Each plugin defined its own error domain, though none actually defined any errors. Replace these with appropriate uses of NM_SETTINGS_ERROR_INVALID_CONNECTION and NM_SETTINGS_ERROR_FAILED.

d13bfe3 settings: drop plugin-specific error domains
src/Makefile.am | 1 -
src/settings/plugins/example/Makefile.am | 1 -
src/settings/plugins/example/common.h | 11 -
src/settings/plugins/example/errors.c | 40 ----
.../plugins/example/nm-example-connection.c | 2 +-
src/settings/plugins/ibft/Makefile.am | 4 +-
src/settings/plugins/ibft/errors.c | 34 ----
src/settings/plugins/ibft/errors.h | 29 ---
src/settings/plugins/ibft/nm-ibft-connection.c | 1 -
src/settings/plugins/ibft/plugin.c | 1 -
src/settings/plugins/ibft/reader.c | 32 +--
src/settings/plugins/ibft/tests/Makefile.am | 1 -
src/settings/plugins/ibft/tests/test-ibft.c | 3 +-
src/settings/plugins/ifcfg-rh/Makefile.am | 1 -
src/settings/plugins/ifcfg-rh/common.h | 4 -
src/settings/plugins/ifcfg-rh/errors.c | 35 ----
.../plugins/ifcfg-rh/nm-ifcfg-connection.c | 24 +--
src/settings/plugins/ifcfg-rh/plugin.c | 3 +-
src/settings/plugins/ifcfg-rh/reader.c | 214 +++++++++++---------
src/settings/plugins/ifcfg-rh/tests/Makefile.am | 1 -
.../plugins/ifcfg-rh/tests/test-ifcfg-rh.c | 20 +-
src/settings/plugins/ifcfg-rh/writer.c | 67 +++---
src/settings/plugins/ifcfg-suse/plugin.c | 11 -
src/settings/plugins/ifcfg-suse/plugin.h | 2 -
src/settings/plugins/ifnet/Makefile.am | 4 +-
src/settings/plugins/ifnet/connection_parser.c | 123 ++++++-----
src/settings/plugins/ifnet/errors.c | 35 ----
src/settings/plugins/ifnet/errors.h | 30 ---
src/settings/plugins/ifnet/tests/Makefile.am | 3 +-
src/settings/plugins/ifupdown/parser.c | 23 +--
src/settings/plugins/ifupdown/plugin.h | 2 -
src/settings/plugins/keyfile/Makefile.am | 1 -
src/settings/plugins/keyfile/common.h | 3 -
src/settings/plugins/keyfile/errors.c | 35 ----
.../plugins/keyfile/nm-keyfile-connection.c | 2 +-
src/settings/plugins/keyfile/plugin.h | 2 -
src/settings/plugins/keyfile/reader.c | 6 +-
src/settings/plugins/keyfile/tests/Makefile.am | 1 -
src/settings/plugins/keyfile/writer.c | 18 +-
39 files changed, 271 insertions(+), 559 deletions(-)

Upstream: cgit.freedesktop.org

  • Share