settings: implement ability to add connections without saving them to disk

System Internals / NetworkManager - Dan Williams [redhat.com] - 28 May 2013 12:26 UTC

We don't always want to immediately write new connections to disk, to facilitate "runtime" or "temporary" connections where an interface's runtime config isn't backed by on-disk config. Also, just because an interface's configuration is changed doesn't necessarily mean that new configuration should be written to disk either.

Add D-Bus methods for adding new connections and for updating existing connections that don't immediately save the connection to disk.

Also add infrastructure to indicate to plugins that the new connection shouldn't be immediately saved if the connection was added with the new method.

8a79fb1 settings: implement ability to add connections without saving them to disk
introspection/nm-settings-connection.xml | 26 +++++-
introspection/nm-settings.xml | 21 +++++
src/nm-manager.c | 1 +
src/settings/nm-settings-connection.c | 113 +++++++++++++++++-------
src/settings/nm-settings.c | 91 ++++++++++++-------
src/settings/nm-settings.h | 1 +
src/settings/nm-system-config-interface.c | 3 +-
src/settings/nm-system-config-interface.h | 7 +-
src/settings/plugins/example/plugin.c | 10 ++-
src/settings/plugins/ifcfg-rh/plugin.c | 17 +++-
src/settings/plugins/ifcfg-rh/writer.c | 33 +++++--
src/settings/plugins/ifcfg-rh/writer.h | 3 +
src/settings/plugins/ifnet/Makefile.am | 4 +-
src/settings/plugins/ifnet/connection_parser.c | 76 ++++++++++++++--
src/settings/plugins/ifnet/connection_parser.h | 2 +
src/settings/plugins/ifnet/errors.c | 35 ++++++++
src/settings/plugins/ifnet/errors.h | 30 +++++++
src/settings/plugins/ifnet/net_utils.c | 11 ---
src/settings/plugins/ifnet/net_utils.h | 2 -
src/settings/plugins/ifnet/plugin.c | 58 +++++-------
src/settings/plugins/ifnet/tests/Makefile.am | 3 +-
src/settings/plugins/keyfile/plugin.c | 13 +--
22 files changed, 409 insertions(+), 151 deletions(-)

Upstream: cgit.freedesktop.org

  • Share