settings/example: remove 'example' settings plugin

System Internals / NetworkManager - Thomas Haller [redhat.com] - 12 June 2015 08:59 UTC

The 'example' settings plugin is (obviously) unused, but it is also badly maintained and no longer best-practice in several ways:

- it directly reads "NetworkManager.conf" instead of using NMConfig.- it parses device specs itself, instead of using nm_match_spec_split().- read_connections() doesn't ensure that loading a file does not replace a previously loaded one (due to conflicting UUID). In general the example doesn't show/handle the complexity of potential UUID conflicts.

Instead of fixing these issues it is better to ensure our main plugin ('keyfile') corresponds to current best practices. Should we ever add a new pluginww, 'keyfile' should be the example.

e700211 settings/example: remove 'example' settings plugin
configure.ac | 1 -
src/settings/plugins/Makefile.am | 2 +-
src/settings/plugins/README | 33 +
src/settings/plugins/example/Makefile.am | 32 -
src/settings/plugins/example/README | 33 -
src/settings/plugins/example/common.h | 45 --
.../plugins/example/nm-example-connection.c | 189 -----
.../plugins/example/nm-example-connection.h | 55 --
src/settings/plugins/example/plugin.c | 732 --------------------
src/settings/plugins/example/plugin.h | 55 --
src/settings/plugins/example/reader.c | 47 --
src/settings/plugins/example/writer.c | 56 --
12 files changed, 34 insertions(+), 1246 deletions(-)

Upstream: cgit.freedesktop.org


  • Share