Handle border = 3 in expanded mode

Enterprise / PostgreSQL - Stephen Frost [snowman.net] - 12 September 2014 10:11 UTC

In psql, expanded mode was not being displayed correctly when using the normal ascii or unicode linestyles and border set to '3'. Now, per the documentation, border '3' is really only sensible for HTML and LaTeX formats, however, that's no excuse for ascii/unicode to break in that case, and provisions had been made for psql to cleanly handle this case (and it did, in non-expanded mode).

This was broken when ascii/unicode was initially added a good five years ago because print_aligned_vertical_line wasn't passed in the border setting being used by print_aligned_vertical but instead was given the whole printTableContent. There really isn't a good reason for vertical_line to have the entire printTableContent structure, so just pass in the printTextFormat and border setting (similar to how this is handled in horizontal_line).

Pointed out by Pavel Stehule, fix by me.

Back-patch to all currently-supported versions.

8296283 Handle border = 3 in expanded mode
src/bin/psql/print.c | 15 +++++++--------
1 file changed, 7 insertions(+), 8 deletions(-)

Upstream: git.postgresql.org

  • Share