Tweak BRIN minmax operator class

Enterprise / PostgreSQL - Alvaro Herrera [alvh.no-ip.org] - 22 January 2015 14:01 UTC

In the union support proc, we were not checking the hasnulls flag of
value A early enough, so it could be skipped if the "allnulls" flag in
value B is set. Also, a check on the allnulls flag of value "B" was redundant, so remove it.

Also change inet_minmax_ops to not be the default opclass for type inet, as a future inclusion operator class would be more useful and it's pretty difficult to change default opclass for a datatype later on. (There is no catversion bump for this catalog change; this shouldn't be a problem.)

Extracted from a larger patch to add an "inclusion" operator class.

Author: Emre Hasegeli

972bf7d Tweak BRIN minmax operator class
src/backend/access/brin/brin_minmax.c | 19 ++++++++++---------
src/include/catalog/pg_opclass.h | 2 +-
src/test/regress/expected/brin.out | 2 +-
src/test/regress/sql/brin.sql | 2 +-
4 files changed, 13 insertions(+), 12 deletions(-)

Upstream: git.postgresql.org


  • Share