XCB/XVideo: ignore the overlay setting

Multimedia / VLC - Rémi Denis-Courmont [remlab.net] - 30 April 2016 10:56 UTC

XVideo version 2 does not provide visiblity or control over the use of hardware video overlays. That is an implementation detail of the X11 driver. Thus the overlay setting did not really work as advertized. The XVideo adapter setting has to be used instead.

In fact most drivers still in use today do not use overlay, but the 3D engine (either via vendor-specific support or via GLAMOR). And since the XVideo plugin got lower priority than VDPAU and OpenGL, the setting has been redundant: it only has effects if neither VDPAU nor OpenGL are supported (!), and even --no-overlay has the same results as --vout=x11.

de6f4b3 XCB/XVideo: ignore the overlay setting
modules/video_output/xcb/xvideo.c | 3 ---
1 file changed, 3 deletions(-)

Upstream: git.videolan.org

  • Share