refactor detection of guest type capabilities

Enterprise / Virtualization / virt-manager - Pavel Hrdina [redhat.com] - 14 July 2015 12:11 UTC

Each guest type can have its own capabilities and we should always ask only for those capabilities.

The old approach was to get capabilities from libvirt and then for example cycle trough all guests and return True, if any guest type supports kvm or pae, etc.

Now we check those capabilities only for the correct guest type according to defaults and input from user.

3ff3589 refactor detection of guest type capabilities
tests/capabilities.py | 5 +-
.../compare/virt-convert-ovf-compare.xml | 1 -
.../compare/virt-convert-vmx-compare.xml | 1 -
.../compare/virt-install-aarch64-cdrom.xml | 2 -
.../compare/virt-install-aarch64-machdefault.xml | 1 -
.../compare/virt-install-aarch64-machvirt.xml | 1 -
.../compare/virt-install-arm-defaultmach-f20.xml | 1 -
.../compare/virt-install-arm-vexpress-f19.xml | 1 -
.../compare/virt-install-arm-vexpress-plain.xml | 1 -
.../compare/virt-install-arm-virt-f20.xml | 1 -
.../compare/virt-install-f21-kvm-remote.xml | 1 -
.../compare/virt-install-kvm-centos7.xml | 2 -
.../compare/virt-install-kvm-f14-url.xml | 2 -
.../compare/virt-install-kvm-rhel6.xml | 2 -
.../compare/virt-install-kvm-rhel7.xml | 2 -
.../compare/virt-install-kvm-win2k3-cdrom.xml | 3 -
.../compare/virt-install-location-iso.xml | 2 -
.../compare/virt-install-many-devices.xml | 1 -
.../compare/virt-install-ppc64-machdefault-f20.xml | 1 -
.../compare/virt-install-ppc64-pseries-f20.xml | 1 -
.../compare/virt-install-q35-defaults.xml | 2 -
.../compare/virt-install-qemu-plain.xml | 1 -
.../compare/virt-install-singleton-config-1.xml | 1 -
.../compare/virt-install-singleton-config-2.xml | 2 -
.../compare/virt-install-win7-uefi.xml | 3 -
.../cli-test-xml/compare/virt-install-xen-hvm.xml | 1 -
.../ovf2libvirt_ovf_directory.libvirt | 1 -
.../libvirt_output/ovf2libvirt_test1.libvirt | 1 -
.../ovf2libvirt_test1.libvirt.disk_qcow2 | 1 -
.../libvirt_output/ovf2libvirt_test2.libvirt | 1 -
.../vmx2libvirt_test-nodisks.libvirt | 1 -
.../vmx2libvirt_test-vmx-zip.libvirt | 1 -
.../libvirt_output/vmx2libvirt_test1.libvirt | 1 -
.../vmx2libvirt_test1.libvirt.disk_raw | 1 -
.../libvirt_output/vmx2libvirt_vmx-dir.libvirt | 1 -
tests/xmlconfig.py | 2 +-
virtManager/create.py | 9 +--
virtinst/capabilities.py | 82 +++++++++-----------
virtinst/guest.py | 5 +-
39 files changed, 47 insertions(+), 102 deletions(-)

Upstream: git.fedorahosted.org

  • Share