arm: Prevent compilation of old, experimental SMP support

Hardware / Coreboot - Julius Werner [chromium.org] - 2 April 2015 10:27 UTC

The ARM SMP feature was added a long time ago and has never really been used by anyone since. We are still always compiling cpu_info() even though we don't use it, and it makes some dangerous assumptions about stack alignment that are not guaranteed anywhere.

I'm planning to change the way the stack boundaries are defined. Rather than trying to work that into this unsafe, unused and hard to test feature, I think we should just seal it off with police tape and make sure that if anyone ever tries to use it again (which currently seems unlikely), they get forced to do their due diligence on making sure it works as intended.

BUG=None TEST=Compiled Veyron_Pinky.

Change-Id: Id25545cab88f29200c7672ef02c7804f0ac26399

635ee51 arm: Prevent compilation of old, experimental SMP support
src/arch/arm/Makefile.inc | 2 +-
src/arch/arm/cpu.c | 5 +++++
2 files changed, 6 insertions(+), 1 deletion(-)

Upstream: review.coreboot.org

  • Share