google/reef: Enable 20K pull ups for LPC CLKRUN and LAD0:3 lines

Hardware / Coreboot - Shamile Khan [intel.com] - 6 September 2016 13:22 UTC

The pull up for CLKRUN is required to resolve keyboard slowness and malfunctioning observed on some reef systems. The CLKRUN signal was probed and found to be floating when the pull up was not enabled. Also Added pull ups for the LPC Multiplexed command, address and data lines LAD0:3 because the LPC Interface specification requires them.

BUG=chrome-os-partner:55586 BRANCH=none TEST=When a key is pressed, the character is immediately visible on the screen. Also the interrupt count for i8042 increments immediately in /proc/interrupts.

Change-Id: I16df1a0301a3994c926a609f61291761219f9e01

93c5470 google/reef: Enable 20K pull ups for LPC CLKRUN and LAD0:3 lines
.../google/reef/variants/baseboard/gpio.c | 10 +++++-----
src/soc/intel/apollolake/lpc_lib.c | 9 +++++----
2 files changed, 10 insertions(+), 9 deletions(-)

Upstream: review.coreboot.org

  • Share